Please fix the forgegradle problem and support for Scriptapi1 in b74

[ybyyby_ awa]

Please fix the forgegradle problem and support for Scriptapi1 in b74
I'm really bored. Countless scripts can't be used. Countless problems and scripts need to be updated. This is a community, but it doesn't mean we need to work for free. Even if I write a tool that can convert api1 scripts into api2 scripts with one click, there are still a lot of error correction steps. Who doesn't want to use the latest version of liquidbond? But we can't give up our work, so please fix the forgegradle problem and support for Scriptapi1 in b74

[ybyyby_ awa]

[kawaiinekololis]

@ybyyby_-awa How about you tell me what is not working? Also stop using v1, we are supporting it for years now and you did not manage to update to v2. Many of the scripts are depending on client internal features which were never intended to be used by script developers, but there we are, now everyone expects US to make THEIR scripts work forever??

From my testing everything was fine when I published b74, so how am I supposed what is your issue if you just come here and try to hate on us.
ForgeGradle works fine too. If you try to develop on LiquidBounce, it is your problem if you don't even know how to setup the workspace.

btw https://howoldisminecraft188.today/

ALSO "we need to work for free" LMAO. DID YOU EVER PAY ME?

[kawaiinekololis]

Also I don't understand how you think that we would not support ScriptAPI v1 anymore? It is still supported in b74 and we did not even change a thing since b73 on the ScriptAPI.

Last change was from last year.

https://github.com/CCBlueX/LiquidBounce/blob/legacy/src/main/resources/assets/minecraft/liquidbounce/scriptapi/legacy.js

[CzechHek]

@kawaiinekololis said in Please fix the forgegradle problem and support for Scriptapi1 in b74:

@ybyyby_-awa How about you tell me what is not working?

Made an issue about this 7 months ago, saying that Nashorn or remapper doesn't work since ForgeGradle update causing things such as mc.thePlayer to be undefined.

https://github.com/CCBlueX/LiquidBounce/issues/817

Duplicate of mine post: https://github.com/CCBlueX/LiquidBounce/issues/823

CzechHek created this issue in CCBlueX/LiquidBounce

closed [BUG] Critical issues with legacy LB #817

LivesTraveler created this issue in CCBlueX/LiquidBounce

closed [BUG]All js are invalid in the latest b73 #823

[kawaiinekololis]

@CzechHek It is odd that the "update" of ForgeGradle would cause this issue, but I'll look into it. The SRGs are loaded from external source and I mean, minecraft itself is always the same, but maybe something we depend on has changed.

We did fork the ForgeGradle to make sure it does not go down anymore.
https://github.com/CCBlueX/ForgeGradle
This is why I hate working on 1.8 things. Everything is just outdated af and does not even exist anymore.

But still does not explain why ForgeGradle should affect our remapper.

[CatsAreBasedFr]

@ybyyby_-awa @kawaiinekololis @CzechHek Cat

[kawaiinekololis]

It seems AbstractJavaLinkerTransformer is not being registered anymore which causes the remapper not being injected into Nashorn.

[kawaiinekololis]

fixed.

No errors while Animations module is turned on.

and is working fine (ofc cannot show cuz pic and not gif)

[kawaiinekololis]

So it had NOTHING to do with ForgeGradle what I expected, but someone accidently removed the transformers for AntiForge and the JS remapper. I still know that some people had issues when joining servers with AntiForge enabled, yeah, that was probably the reason.

@CzechHek @ybyyby_-awa Please try https://github.com/CCBlueX/LiquidBounce/commit/8e464765e5d906a3e8cd0ad780add68f73101d89

0 kawaiinekololis committed to CCBlueX/LiquidBounce

fixed JS Remapper and Anti-Forge transformer not being assigned

This caused issues with Anti-Forge not working anymore + and made every JS invalid causing mc functions not being remapped anymore.
More about it here: https://forums.ccbluex.net/topic/7450/please-fix-the-forgegradle-problem-and-support-for-scriptapi1-in-b74/

[CatsAreBasedFr]

@kawaiinekololis Yeah sir you still saying absolutely right

[kawaiinekololis]

https://github.com/CCBlueX/LiquidBounce/commit/313184df0f874ed6550888410fb9aabf4c2af07a
https://github.com/CCBlueX/LiquidBounce/compare/b74...b75

However, I have decided to make this a hotfix update due to the critical issue with the ScriptAPI. Sorry for the inconvenience

Tested:
fixed scripts – 00:21
— 1zuna 生活

0 kawaiinekololis committed to CCBlueX/LiquidBounce

b75 release.

[CzechHek]

@kawaiinekololis Thank you for fixing the ScriptAPI, however, the Microsoft login still doesn't work even after this update. Now it correctly redirects to http://localhost:1919/login?code=....... but this site fails because of empty response and then connection refused. LB keeps logging in and when you click on cancel, it crashes.

Log (crash report): https://pastebin.com/raw/LHwb9aAs
(latest.log https://pastebin.com/raw/9WYyjxSJ)

[ybyyby_ awa]

@kawaiinekololis Thanks for repairing! Also about "we need to work for free"
You may have misunderstood it (hey, my English is not good, maybe I have a problem with my expression)
I mean I need a lot of work to develop api conversion tools
Sorry,Please forgive me for being impolite hahahaha
Anyway! Thanks for repairing!!!!!!!!!!!!!!!!!!
I love you!

[kawaiinekololis]

@CzechHek ah shoot, when I tested it it seemed to work fine. I'll look into it and fix it soon.

Edit: I am stupid, changes something after testing and this caused it to break lmao